Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Brownfields, Green Belt areas, and Ramsar sites to constraints check #2710

Merged
merged 5 commits into from
Jan 30, 2024
Merged

feat: add Brownfields, Green Belt areas, and Ramsar sites to constraints check #2710

merged 5 commits into from
Jan 30, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jan 29, 2024 •
edited
Loading

  • Adds three additional dataset checks to Planning Constraints
  • Bumps planx-core & ODP Schema so that submissions which include these constraints will be valid
  • [non-code] Updates Notion service spec "What we check" here & onboarding checklist here

@jessicamcinchak
Copy link
Member Author

Add additional planning constraint datasets

jessicamcinchak
jessicamcinchak commented Jan 29, 2024
View reviewed changes
api.planx.uk/modules/gis/service/local_authorities/metadata/base.ts
@@ -27,25 +27,18 @@ const baseSchema: PlanningConstraintsBaseSchema = {
"digital-land-datasets": ["central-activities-zone"],
category: "General policy",
},
listed: {
brownfieldSite: {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've alphabetised the active datasets while here - apologies it makes for a noisy diff!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak mentioned this pull request Jan 30, 2024
Merged
@jessicamcinchak jessicamcinchak mentioned this pull request Jan 30, 2024
Merged
@jessicamcinchak jessicamcinchak marked this pull request as ready for review January 30, 2024 12:22
@jessicamcinchak jessicamcinchak requested a review from a team January 30, 2024 12:22
@jessicamcinchak jessicamcinchak merged commit 96af82d into main Jan 30, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/add-constraints branch January 30, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamcinchak @DafyddLlyr